Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Add quality of life improvements to the Devcontainer #703

Closed
5 of 7 tasks
Tracked by #701
mdemoret-nv opened this issue Feb 14, 2023 · 1 comment · Fixed by #717
Closed
5 of 7 tasks
Tracked by #701

[FEA] Add quality of life improvements to the Devcontainer #703

mdemoret-nv opened this issue Feb 14, 2023 · 1 comment · Fixed by #717
Assignees
Labels
feature request New feature or request

Comments

@mdemoret-nv
Copy link
Contributor

mdemoret-nv commented Feb 14, 2023

After #702 is implemented, the devcontainer could be improved with some quality of life features. Most of these are nice to have and could be separated out into different issues if difficult to implement:

  • Create a script to install pytest-kafka (See this for an example taken from the CI runner image)
  • Setup the VS Code max file watchers to prevent warnings that there are too many files to watch in the folder.
  • Add the necessary X Server bindings to support opening the Morpheus Visualization demos from the devcontainer
  • Setup Git LFS storage property to map back to the host to reduce LFS bandwidth
    • Requires setting the user's global git config lfs.storage property to a directory mounted from the host
  • Install .NET to allow the CMake extension to use the language server features. (Example here)
  • Use docker-compose with devcontainers to streamline setting up the docker network
@mdemoret-nv mdemoret-nv added the feature request New feature or request label Feb 14, 2023
@mdemoret-nv mdemoret-nv changed the title Add quality of life improvements to the Devcontainer [FEA] Add quality of life improvements to the Devcontainer Feb 14, 2023
@cwharris
Copy link
Contributor

cwharris commented Feb 23, 2023

Git LFS storage directory is designed to be a sub-directory of the .git repository directory which will be mounted in to the container, so modifying lfs.storage is not necessary for it to be used by both the host and container.

@jarmak-nv jarmak-nv moved this from Todo to In Progress in Morpheus Boards Feb 27, 2023
@jarmak-nv jarmak-nv moved this from In Progress to Review in Morpheus Boards Feb 27, 2023
@rapids-bot rapids-bot bot closed this as completed in #717 Mar 8, 2023
@rapids-bot rapids-bot bot closed this as completed in e36419f Mar 8, 2023
@github-project-automation github-project-automation bot moved this from Review to Done in Morpheus Boards Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants