Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fork-ts-checker-webpack-plugin (typescript-build package) require versions is incorrect #389

Closed
hanhdz025 opened this issue Jul 1, 2020 · 4 comments · Fixed by #391
Closed

Comments

@hanhdz025
Copy link

hanhdz025 commented Jul 1, 2020

I use lerna to install nuxtjs and nestjs for my project, so my fork-ts-checker-webpack-plugin having two versions 5.x and 4.1.6, this.nuxt.resolver.resolveModule code below require fork-ts-checker-webpack-plugin 5.x version instead of version 4.1.6
image

My current solution is install it on package.json in nuxt app
image

Can remove it in the next versions?

@kevinmarrec
Copy link
Contributor

@hanh-dev We can't remove it, it's a main feature 😅, but I'm currently trying to upgrade it to 5.x so it will fix your issue :)

@kevinmarrec
Copy link
Contributor

kevinmarrec commented Jul 1, 2020

(If it installs 5.x it means another package you're using is requiring 5.x somehow, most probably nestjs you mentioned)

@kevinmarrec
Copy link
Contributor

kevinmarrec commented Jul 1, 2020

See TypeStrong/fork-ts-checker-webpack-plugin#452 why I can't upgrade to 5.x for now, I suggest you to do this instead in your package.json :

"dependencies": {
  // ...
},
"resolutions": {
  "fork-ts-checker-webpack-plugin": "4.1.6"
}

To force nestjs to use 4.1.6 and fix your issues.

EDIT : Bad idea, it will most probably break if they use it in their code, there have been multiple breaking changes

@kevinmarrec
Copy link
Contributor

kevinmarrec commented Jul 1, 2020

@hanh-dev It will be fixed when the package will be fixed 😅, the new version doesn't provide errors for *.vue files anymore, and it's the main feature when used in Vue projects 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants