Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error "Cannot convert undefined or null to object" after upgrade from 2.6.3 to 3.0.x #30

Closed
abenhamdine opened this issue Nov 9, 2018 · 2 comments

Comments

@abenhamdine
Copy link

abenhamdine commented Nov 9, 2018

Version

v3.0.3

Reproduction link

https://github.com/nuxt/webpackbar

Steps to reproduce

Build a project with create-react-app, webpack 3 and react-app-rewired, with following config-override :

module.exports = {
	webpack: function (config, env) {

		config.plugins = (config.plugins || []).concat([
			new WebpackBar({
				profile: true,
			})
		])

		return config

	}
}

Or way to reproduce the issue : run tests for ant-design project (https://github.com/ant-design/ant-design) with npm run dist.
See CI failure here : https://circleci.com/gh/ant-design/ant-design/24699?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link.
The upgrade has been reverted since by this commit : ant-design/ant-design@5204b45

What is expected ?

No error

What is actually happening?

Error Cannot convert undefined or null to object

This bug report is available on Nuxt community (#c23)
@ghost ghost added the cmty:bug-report label Nov 9, 2018
@abenhamdine abenhamdine changed the title Cannot convert undefined or null to object after upgraded from 2.6.3 to 3.0.3 Error "Cannot convert undefined or null to object" after upgrade from 2.6.3 to 3.0.x Nov 9, 2018
pi0 added a commit that referenced this issue Nov 9, 2018
@pi0
Copy link
Member

pi0 commented Nov 9, 2018

Thanks, @abenhamdine for reporting this important inconsistency. The main fix was 8f0085a. But after that I tried to make several improvements to ensure more stability and published new changes :) Please feel reporting back if it works for you or not.

@pi0 pi0 closed this as completed Nov 9, 2018
@abenhamdine
Copy link
Author

version 3.1.2 fixed that issue and works perfectly 👍
Thx for your responsiveness and for this great module !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants