fix: Remove lodash and replace table #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the much smaller single util packages.
table is 29.2KB based on https://bundlephobia.com/[email protected] it also has a 3MB install size. It also has a dependency on lodash. text-table has no dependencies and is 11KB in total.
|
It seems like there's only a check on Windows 🤔 |
|
Hi. Thanks for this PR. I really appreciate your help. Regarding Most of the users are using this package alongside with other dependencies that depend on |
pi0
added a commit
that referenced
this pull request
Oct 31, 2018
pi0
added a commit
that referenced
this pull request
Oct 31, 2018
|
@timneutkens Really thanks for your contribution. I've removed lodash dependency (at all) and replaced |
|
💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of unjs/consola#20
lodashhas a 1.1MB install size and is 60% of webpackbar according to bundlephobia and packagephobia:Regarding replacing the
tabledependency:table is 29.2KB based on bundlephobia.com/[email protected] it also has a 3MB install size and has a dependency on lodash.
text-table has no dependencies and is 11KB in total.
The goal of the PR is just to replace lodash, maybe some of these functions can be removed alltogether