Pass H3Event into useRuntimeConfig for serverSupabaseServiceRole #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm having issues in production because of this. My environment variables are not actually being respected. Per Nuxt's documentation: https://nuxt.com/docs/guide/going-further/runtime-config#server-routes > Giving the event as argument to useRuntimeConfig is optional, but it is recommended to pass it to get the runtime config overwritten by environment variables at runtime for server routes.
👷 Deploy request for n3-supabase pending review.Visit the deploys page to approve it
|
|
It's a good fix and good practice thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
I'm having issues in production because my environment variables are not actually being respected. No problems locally while developing, but when I look at the values that are being pulled for
serviceKeyandurlin production, they are not receiving the override that I expect from my environment variables. I believe this is the culprit.Per Nuxt's documentation:
I have tested this using patch-package and confirmed that doing this fixes the behavior.
Is this a bad idea for some reason I'm not aware of?