Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use tapable hooks #103

Merged
merged 2 commits into from
Nov 11, 2018
Merged

Conversation

TheAlexLichter
Copy link
Member

No description provided.

@TheAlexLichter TheAlexLichter requested a review from pi0 November 10, 2018 12:02
@codecov
Copy link

codecov bot commented Nov 10, 2018

Codecov Report

Merging #103 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #103   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         1      1           
  Lines         2      2           
===================================
  Hits          2      2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9062be...a97320e. Read the comment docs.

@pi0
Copy link
Member

pi0 commented Nov 11, 2018

This PR will break Nuxt 1 users. So we should ship it with a semver/major.

@pi0 pi0 merged commit 9f27d5c into nuxt-community:dev Nov 11, 2018
@TheAlexLichter TheAlexLichter deleted the update-tapable branch November 11, 2018 12:00
@TheAlexLichter
Copy link
Member Author

@pi0 Agreed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants