Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the FST configuration to the HTMObjectInput/HTMObjectOutput #418

Closed
EronWright opened this issue May 2, 2016 · 4 comments
Closed

Pass the FST configuration to the HTMObjectInput/HTMObjectOutput #418

EronWright opened this issue May 2, 2016 · 4 comments

Comments

@EronWright
Copy link
Contributor

I notice that FSTObjectInput has an overloaded constructor to take the FSTConfiguration. I think the SerializerCore should pass the fastSerialConfig to the HTM input and output classes. The current behavior is that the default config is used.
@EronWright EronWright mentioned this issue May 2, 2016
Closed
@cogmission
Copy link
Collaborator

cogmission commented May 2, 2016 •
edited
Loading

@EronWright Then are you suggesting that there be a way to pass in a FSTConfiguration of your own?

@cogmission
Copy link
Collaborator

@EronWright I see, that way we prevent 2 from being created... Makes sense! Thanks!

@cogmission
Copy link
Collaborator

👍 done.

@cogmission cogmission mentioned this issue May 2, 2016
Merged
@cogmission
Copy link
Collaborator

Fixed in #419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EronWright @cogmission