Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding/Removing timestamps not working as expected #2342

Closed
whynowy opened this issue Jan 19, 2025 · 1 comment · Fixed by #2374
Closed

Adding/Removing timestamps not working as expected #2342

whynowy opened this issue Jan 19, 2025 · 1 comment · Fixed by #2374
Assignees
Labels
area/ui User Interface bug Something isn't working
Milestone

Comments

@whynowy
Copy link
Member

whynowy commented Jan 19, 2025

Describe the bug

Image Image

To Reproduce
Steps to reproduce the behavior:

Create a simple pipeline and check the pod logs from different vertices, try out the add/remove timestamps feature.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

  • Kubernetes: [e.g. v1.18.6]
  • Numaflow: [e.g. v0.5.1]

Additional context
Add any other context about the problem here.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We often sort issues this way to know what to prioritize.

For quick help and support, join our slack channel.

@whynowy whynowy added area/ui User Interface bug Something isn't working labels Jan 19, 2025
@vigith vigith added this to the 1.5 milestone Jan 20, 2025
@veds-g
Copy link
Contributor

veds-g commented Jan 21, 2025

The reason filtering does not work here is because unlike source and cat vertex, sink does not have an object in logs. The timestamp is extracted from the log object for source and cat, but for sink it is just a string. Can we generalise the log format so its easy to apply the filters or should I handle it separately for this sink log string (provided it remains consistent).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui User Interface bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants