Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(multi-version): error when generating manifests for multiple versions #12

Open
lander2k2 opened this issue Jun 8, 2022 · 1 comment

Comments

@lander2k2
Copy link
Contributor

Running make manifests results in the following:

/Users/sdustin/go/bin/controller-gen "crd:preserveUnknownFields=false,crdVersions=v1,trivialVersions=true" rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd/bases
github.com/vmware-tanzu-labs/namespace-operator/apis/tenancy/v1alpha2:-: CRD for TanzuNamespace.tenancy.platform.cnr.vmware.com has no storage version
Error: not all generators ran successfully
run `controller-gen crd:preserveUnknownFields=false,crdVersions=v1,trivialVersions=true rbac:roleName=manager-role webhook paths=./... output:crd:artifacts:config=config/crd/bases -w` to see all available markers, or `controller-gen crd:preserveUnknownFields=false,crdVersions=v1,trivialVersions=true rbac:roleName=manager-role webhook paths=./... output:crd:artifacts:config=config/crd/bases -h` for usage
make: *** [manifests] Error 1

It appears adding +kubebuilder:storageversion will fix the issue (see kubernetes-sigs/controller-tools#390). Anything else (e.g. I support v1beta2 but i submit a v1beta1 resources) will result in a conversion webhook doing the conversion.

This doesn't appear to work when I try it, however I'm still playing around with this.

@lander2k2
Copy link
Contributor Author

Original issue:
vmware-archive/operator-builder#190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant