Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve new integration tests #219

Closed
tatiana-nspcc opened this issue Jun 3, 2024 · 0 comments · Fixed by #221
Closed

Improve new integration tests #219

tatiana-nspcc opened this issue Jun 3, 2024 · 0 comments · Fixed by #221
Assignees
@tatiana-nspcc
Labels
bug Something isn't working I4 No visible changes S4 Routine test Unit tests U3 Regular

Comments

@tatiana-nspcc
Copy link
Contributor

tatiana-nspcc commented Jun 3, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

Sometimes coverage tests failed with an error:

=== RUN   TestIntegration/nspccdev/neofs-aio:0.41.0/rest_new_head_by_attribute/head
    integration_test.go:2200: 
        	Error Trace:	/home/runner/work/neofs-rest-gw/neofs-rest-gw/cmd/neofs-rest-gw/integration_test.go:2200
        	Error:      	Not equal: 
        	            	expected: "Mon, 03 Jun 2024 12:52:17 GMT"
        	            	actual  : "Mon, 03 Jun 2024 12:52:18 GMT"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-Mon, 03 Jun 2024 12:52:17 GMT
        	            	+Mon, 03 Jun 2024 12:52:18 GMT
        	Test:       	TestIntegration/nspccdev/neofs-aio:0.41.0/rest_new_head_by_attribute/head
=== RUN   TestIntegration/nspccdev/neofs-aio:0.41.0/rest_new_head_by_attribute/head_multi-segment_path_attribute
    integration_test.go:2238: 
        	Error Trace:	/home/runner/work/neofs-rest-gw/neofs-rest-gw/cmd/neofs-rest-gw/integration_test.go:2238
        	Error:      	Not equal: 
        	            	expected: "Mon, 03 Jun 2024 12:52:18 GMT"
        	            	actual  : "Mon, 03 Jun 2024 12:52:17 GMT"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-Mon, 03 Jun 2024 12:52:18 GMT
        	            	+Mon, 03 Jun 2024 12:52:17 GMT
        	Test:       	TestIntegration/nspccdev/neofs-aio:0.41.0/rest_new_head_by_attribute/head_multi-segment_path_attribute

And I need to rerun this job.

Describe the solution you'd like

Some improvements are needed in this test to calculate the timestamp.

Additional context

v0.9.0
@tatiana-nspcc tatiana-nspcc added U3 Regular enhancement Improving existing functionality S3 Minimally significant I2 Regular impact labels Jun 3, 2024
@tatiana-nspcc tatiana-nspcc self-assigned this Jun 3, 2024
@roman-khimov roman-khimov added bug Something isn't working S4 Routine I4 No visible changes test Unit tests and removed enhancement Improving existing functionality S3 Minimally significant I2 Regular impact labels Jun 3, 2024
@tatiana-nspcc tatiana-nspcc mentioned this issue Jun 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tatiana-nspcc tatiana-nspcc

Labels
bug Something isn't working I4 No visible changes S4 Routine test Unit tests U3 Regular
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: Add new function to get object creation Timestamp nspcc-dev/neofs-rest-gw
2 participants
@roman-khimov @tatiana-nspcc