Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples neo-go outdated dependencies make tests useless #3803

Open
AliceInHunterland opened this issue Feb 3, 2025 · 0 comments
Open

examples neo-go outdated dependencies make tests useless #3803

AliceInHunterland opened this issue Feb 3, 2025 · 0 comments
Labels
dependencies Dealing with project dependencies enhancement Improving existing functionality go Go language related I4 No visible changes S4 Routine U4 Nothing urgent

Comments

@AliceInHunterland
Copy link
Contributor

AliceInHunterland commented Feb 3, 2025

Is your feature request related to a problem? Please describe.

We didn't catch this #3802 bug earlier because

github.com/nspcc-dev/neo-go v0.106.3
neo-go dependency wasn't updated with the new release.

Describe the solution you'd like

Update examples dependency automatically. Something like:

cd "$root"/examples/zkp/cubic_circuit || exit 1
go get -u github.com/nspcc-dev/neo-go
go mod tidy

cd "$root"/examples/nft-nd-nns || exit 1
go get -u github.com/nspcc-dev/neo-go
go mod tidy

But update_deps.sh isn't the perfect place for it as it updates only interop dependencies. Maybe dependabot?

Describe alternatives you've considered

Remember about it and update it every time manually.

@AliceInHunterland AliceInHunterland added dependencies Dealing with project dependencies enhancement Improving existing functionality go Go language related I4 No visible changes S4 Routine U4 Nothing urgent labels Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dealing with project dependencies enhancement Improving existing functionality go Go language related I4 No visible changes S4 Routine U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

1 participant