diff --git a/cli/server/server.go b/cli/server/server.go index b3f9ec22b9..64af4c528b 100644 --- a/cli/server/server.go +++ b/cli/server/server.go @@ -505,7 +505,7 @@ func startServer(ctx *cli.Context) error { } errChan := make(chan error) rpcServer := rpcsrv.New(chain, cfg.ApplicationConfiguration.RPC, serv, oracleSrv, log, errChan) - serv.AddService(&rpcServer) + serv.AddService(rpcServer) serv.Start() if !cfg.ApplicationConfiguration.RPC.StartWhenSynchronized { @@ -561,10 +561,10 @@ Main: logLevel.SetLevel(newLogLevel) log.Warn("using new logging level", zap.Stringer("level", newLogLevel)) } - serv.DelService(&rpcServer) + serv.DelService(rpcServer) rpcServer.Shutdown() rpcServer = rpcsrv.New(chain, cfgnew.ApplicationConfiguration.RPC, serv, oracleSrv, log, errChan) - serv.AddService(&rpcServer) + serv.AddService(rpcServer) if !cfgnew.ApplicationConfiguration.RPC.StartWhenSynchronized || serv.IsInSync() { // Here similar to the initial run (see above for-loop), so async. go rpcServer.Start() diff --git a/internal/testcli/executor.go b/internal/testcli/executor.go index 24957db0e5..7ec80513ce 100644 --- a/internal/testcli/executor.go +++ b/internal/testcli/executor.go @@ -178,7 +178,7 @@ func NewTestChain(t *testing.T, f func(*config.Config), run bool) (*core.Blockch rpcServer := rpcsrv.New(chain, cfg.ApplicationConfiguration.RPC, netSrv, nil, logger, errCh) rpcServer.Start() - return chain, &rpcServer, netSrv + return chain, rpcServer, netSrv } func NewExecutor(t *testing.T, needChain bool) *Executor { diff --git a/pkg/services/rpcsrv/server.go b/pkg/services/rpcsrv/server.go index f25beae045..ecd8b42b7c 100644 --- a/pkg/services/rpcsrv/server.go +++ b/pkg/services/rpcsrv/server.go @@ -269,7 +269,7 @@ var rpcWsHandlers = map[string]func(*Server, params.Params, *subscriber) (any, * // New creates a new Server struct. Pay attention that orc is expected to be either // untyped nil or non-nil structure implementing OracleHandler interface. func New(chain Ledger, conf config.RPC, coreServer *network.Server, - orc OracleHandler, log *zap.Logger, errChan chan<- error) Server { + orc OracleHandler, log *zap.Logger, errChan chan<- error) *Server { protoCfg := chain.GetConfig().ProtocolConfiguration if conf.SessionEnabled { if conf.SessionExpirationTime <= 0 { @@ -339,7 +339,7 @@ func New(chain Ledger, conf config.RPC, coreServer *network.Server, } } - return Server{ + return &Server{ http: httpServers, https: tlsServers, diff --git a/pkg/services/rpcsrv/server_helper_test.go b/pkg/services/rpcsrv/server_helper_test.go index 35ef5ae49e..97065a13d3 100644 --- a/pkg/services/rpcsrv/server_helper_test.go +++ b/pkg/services/rpcsrv/server_helper_test.go @@ -131,7 +131,7 @@ func wrapUnitTestChain(t testing.TB, chain *core.Blockchain, orc OracleHandler, handler := http.HandlerFunc(rpcServer.handleHTTPRequest) srv := httptest.NewServer(handler) t.Cleanup(srv.Close) - return chain, &rpcServer, srv + return chain, rpcServer, srv } func initClearServerWithCustomConfig(t testing.TB, ccfg func(configuration *config.Config)) (*core.Blockchain, *Server, *httptest.Server) {