Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt new NeoModules plugins build scheme #147

Open
AnnaShaleva opened this issue Nov 29, 2023 · 1 comment
Open

Adapt new NeoModules plugins build scheme #147

AnnaShaleva opened this issue Nov 29, 2023 · 1 comment
Labels
enhancement Improving existing functionality I4 No visible changes S3 Minimally significant U3 Regular

Comments

@AnnaShaleva
Copy link
Member

We have multiple dockerfiles for C# node building, and we need to ensure that we don't copy plugin-made builds of Neo/NeoVM/other dependent libraries. The overall result of current builds must match the neo-project/neo-modules#846. We also probably need to update our build configurations.

This problem will gone with neo-project/neo#2944, so if we're not adapting NeoC# build scheme until neo-project/neo#2944, then this issue is not relevant afterward.
@AnnaShaleva AnnaShaleva added the enhancement Improving existing functionality label Nov 29, 2023
@roman-khimov roman-khimov added U3 Regular S3 Minimally significant I4 No visible changes labels Dec 20, 2023
@roman-khimov
Copy link
Member

We need to build correctly while modules are still a separate thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improving existing functionality I4 No visible changes S3 Minimally significant U3 Regular
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roman-khimov @AnnaShaleva