Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider not depending on benedict #219

Closed
psarka opened this issue Mar 22, 2023 · 4 comments
Closed

Consider not depending on benedict #219

psarka opened this issue Mar 22, 2023 · 4 comments

Comments

@psarka
Copy link
Contributor

psarka commented Mar 22, 2023

The python-benedict dependency is pretty heavy in terms of sub-dependencies it pulls in:

> conda-tree depends python-benedict
python
requests
pyyaml
python-dateutil
ftfy
mailchecker
phonenumbers
python-fsutil
python-slugify
toml
xmltodict
openpyxl
xlrd

I don't think you are relying on most of these, so it would be nice to replace this by something more lightweight. Should you be open to this, I may find some time to make a PR, let me know :)

@betolink
Copy link
Member

betolink commented Mar 22, 2023

Originally benedict provided some handy methods when accessing very nested JSON objects like the ones returned by NASA's CMR but I'm not apposed to just use the regular Python dict. In fact just this week we were talking about how the results should be represented... it seems like using Pandas to create a table out of the entries from CMR results would be a better way and just printing the raw json.

@psarka
Copy link
Contributor Author

psarka commented Apr 3, 2023

In the same spirit as the benedict case, I would suggest not adding a heavy dependency (such as pandas) just for presentation.

Personally and subjectively I'm fine with raw json. The value proposition of earth access is a nice and simple API to auth and find data.

@fabiocaccamo
Copy link

@psarka @betolink FYI python-benedict supports optional requirements since version 0.29.0.

(I'm the author of python-benedict)

@betolink
Copy link
Member

closing this as we already implemented it.

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in earthaccess project Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants