Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Letting user overload the BR.conf.host #252

Open
Phyks opened this issue Oct 8, 2019 · 7 comments
Open

Letting user overload the BR.conf.host #252

Phyks opened this issue Oct 8, 2019 · 7 comments

Comments

@Phyks
Copy link
Contributor

Phyks commented Oct 8, 2019

Hi,

I'm currently working on a small test suite (more like integration tests rather than unit tests) to help develop BRouter profiles (see abrensch/brouter#116 (comment) for the full issue).

One thing that would be really nice is to be able to link to BRouter-Web (actually brouter.de/brouter-web) below each test case as this would provide a nice user interface to further debug. This link is already there, but not fully working since BRouter-web instance uses the default BRouter instance and not the "testing" one with a fixed set of segments files (fixed in time, for reproducibility).

What about adding an URL parameter to let user overload the BR.conf.host value? This way, the same brouter.de/brouter-web interface could be used for general usage and testing, just by appending a URL parameter.

Thanks!

@nrenner
Copy link
Owner

nrenner commented Oct 10, 2019

I think we wouldn't want to allow everybody to post links to our site with some arbitrary backend.

Will have a look to better understand the use case and what to do instead.

@Phyks
Copy link
Contributor Author

Phyks commented Oct 10, 2019

I think we wouldn't want to allow everybody to post links to our site with some arbitrary backend.

Might be a backend whitelist?

@nrenner
Copy link
Owner

nrenner commented Oct 11, 2019

If there is a separate server installation, the most straightforward solution would be to also have a separate client matching the server version, with a distinct URL.

@bagage
Copy link
Collaborator

bagage commented Apr 14, 2020

@Phyks do you think a test.brouter.xxx would be OK?

@nrenner
Copy link
Owner

nrenner commented Apr 14, 2020

Such a simple switch won't work.

The current test installation on brouter.de is a separate server installtion that needs a separate, matching client.

See abrensch/brouter#209 for a probably better way using the profile parameter forceSecondaryData as a switch.

@bagage
Copy link
Collaborator

bagage commented Apr 14, 2020

@nrenner I meant installing a separate client on test.brouter.xxx (or even http://brouter.de/BrouterTesting-web/ that could be used in the tests - instead of using brouter.de/brouter-web webclient?

@nrenner
Copy link
Owner

nrenner commented Apr 16, 2020

abrensch would prefer using a single client & server installation (comment).

The proposed data switch as a profile flag could be supported in the client either by allowing to pass a custom profile id or by forwarding a profile parameter, that could be implemented like the other provisional parameters until we have a proper general implemenation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants