Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

npm@3 modules that link the same bin can remove a bin it doesn't own #8996

Closed
phated opened this issue Jul 19, 2015 · 7 comments
Closed

npm@3 modules that link the same bin can remove a bin it doesn't own #8996

phated opened this issue Jul 19, 2015 · 7 comments
Labels
bug
Milestone
3.3.0

Comments

@phated
Copy link
Contributor

phated commented Jul 19, 2015

As per @iarna at gulpjs/gulp-cli#7 (comment)

I haven't tested this, but a gulp core contributor tested and linked results at gulpjs/gulp-cli#7 (comment)
@othiym23 othiym23 added the bug label Jul 27, 2015
@othiym23 othiym23 added this to the 3.x milestone Jul 27, 2015
@iarna
Copy link
Contributor

iarna commented Jul 27, 2015

Argh, yes, thank you for making these. =D They've been sitting on my todo list for the past few weeks. <.<

@iarna iarna modified the milestones: 3.x-next-next, 3.x Jul 27, 2015
@iarna iarna modified the milestones: 3.x-next-next, 3.x-next Aug 10, 2015
@iarna iarna mentioned this issue Aug 12, 2015
Closed
@yocontra
Copy link

Any ETA on fixing this? We aren't able to release gulp 4.0 until this is fixed

@iamstarkov
Copy link

im waitin gulp4 for almost one year, pls fix it 🐱

@iarna
Copy link
Contributor

iarna commented Aug 14, 2015

You'll note that this is scheduled for today's release.

@phated
Copy link
Contributor Author

phated commented Aug 14, 2015

Awesome! Thanks @iarna!

@iarna iarna mentioned this issue Aug 14, 2015
Closed
iarna added a commit that referenced this issue Aug 14, 2015
@iarna
gently-rm: Make sure that the thing a symlink links to is inside the …
b31812e 
…thing we're removing

Fixes: #8996
PR-URL: #9198
@iarna
Copy link
Contributor

iarna commented Aug 14, 2015

Hey! Good news! This is out and live in 3.3.0!

@iarna iarna closed this as completed Aug 14, 2015
@phated
Copy link
Contributor Author

phated commented Aug 14, 2015

Hooray! 🎆

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
3.3.0
Development

No branches or pull requests
5 participants
@othiym23 @yocontra @iamstarkov @iarna @phated