Skip to content

Commit 88137a3

Browse files
committed
Previously, `npmlog` was attempting to enable the progress bar even when logs were paused. This displayed the most recent log (most often an error) for the rest of the process. Fixes #4527
1 parent 332914b commit 88137a3

File tree

6 files changed

+13
-17
lines changed

6 files changed

+13
-17
lines changed

node_modules/npmlog/lib/log.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -79,16 +79,12 @@ log.setGaugeTemplate = function (template) {
7979
}
8080

8181
log.enableProgress = function () {
82-
if (this.progressEnabled) {
82+
if (this.progressEnabled || this._paused) {
8383
return
8484
}
8585

8686
this.progressEnabled = true
8787
this.tracker.on('change', this.showProgress)
88-
if (this._paused) {
89-
return
90-
}
91-
9288
this.gauge.enable()
9389
}
9490

node_modules/npmlog/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"author": "GitHub Inc.",
33
"name": "npmlog",
44
"description": "logger for npm",
5-
"version": "7.0.0",
5+
"version": "7.0.1",
66
"repository": {
77
"type": "git",
88
"url": "https://github.com/npm/npmlog.git"
@@ -31,7 +31,7 @@
3131
},
3232
"devDependencies": {
3333
"@npmcli/eslint-config": "^4.0.0",
34-
"@npmcli/template-oss": "4.5.1",
34+
"@npmcli/template-oss": "4.6.1",
3535
"tap": "^16.0.1"
3636
},
3737
"license": "ISC",
@@ -47,6 +47,6 @@
4747
},
4848
"templateOSS": {
4949
"//@npmcli/template-oss": "This file is partially managed by @npmcli/template-oss. Edits may be overwritten.",
50-
"version": "4.5.1"
50+
"version": "4.6.1"
5151
}
5252
}

package-lock.json

+6-6
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@
135135
"npm-profile": "^7.0.1",
136136
"npm-registry-fetch": "^14.0.2",
137137
"npm-user-validate": "^1.0.1",
138-
"npmlog": "^7.0.0",
138+
"npmlog": "^7.0.1",
139139
"opener": "^1.5.2",
140140
"p-map": "^4.0.0",
141141
"pacote": "^15.0.2",
@@ -8409,9 +8409,9 @@
84098409
"license": "BSD-2-Clause"
84108410
},
84118411
"node_modules/npmlog": {
8412-
"version": "7.0.0",
8413-
"resolved": "https://registry.npmjs.org/npmlog/-/npmlog-7.0.0.tgz",
8414-
"integrity": "sha512-p+OVCIQx1Rehplt2DNgBERrKtE5Ej0/rqdcNz5PbohpKHDPprGAl142qQuozmzWUM9uNjvstEO+A92CwytJPcQ==",
8412+
"version": "7.0.1",
8413+
"resolved": "https://registry.npmjs.org/npmlog/-/npmlog-7.0.1.tgz",
8414+
"integrity": "sha512-uJ0YFk/mCQpLBt+bxN88AKd+gyqZvZDbtiNxk6Waqcj2aPRyfVx8ITawkyQynxUagInjdYT1+qj4NfA5KJJUxg==",
84158415
"inBundle": true,
84168416
"dependencies": {
84178417
"are-we-there-yet": "^4.0.0",
@@ -14061,7 +14061,7 @@
1406114061
"npm-package-arg": "^10.0.0",
1406214062
"npm-pick-manifest": "^8.0.1",
1406314063
"npm-registry-fetch": "^14.0.2",
14064-
"npmlog": "^7.0.0",
14064+
"npmlog": "^7.0.1",
1406514065
"pacote": "^15.0.2",
1406614066
"parse-conflict-json": "^3.0.0",
1406714067
"proc-log": "^3.0.0",
@@ -14140,7 +14140,7 @@
1414014140
"@npmcli/run-script": "^5.0.0",
1414114141
"chalk": "^4.1.0",
1414214142
"npm-package-arg": "^10.0.0",
14143-
"npmlog": "^7.0.0",
14143+
"npmlog": "^7.0.1",
1414414144
"pacote": "^15.0.2",
1414514145
"proc-log": "^3.0.0",
1414614146
"read": "^1.0.7",

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@
104104
"npm-profile": "^7.0.1",
105105
"npm-registry-fetch": "^14.0.2",
106106
"npm-user-validate": "^1.0.1",
107-
"npmlog": "^7.0.0",
107+
"npmlog": "^7.0.1",
108108
"opener": "^1.5.2",
109109
"p-map": "^4.0.0",
110110
"pacote": "^15.0.2",

workspaces/arborist/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"npm-package-arg": "^10.0.0",
2525
"npm-pick-manifest": "^8.0.1",
2626
"npm-registry-fetch": "^14.0.2",
27-
"npmlog": "^7.0.0",
27+
"npmlog": "^7.0.1",
2828
"pacote": "^15.0.2",
2929
"parse-conflict-json": "^3.0.0",
3030
"proc-log": "^3.0.0",

workspaces/libnpmexec/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363
"@npmcli/run-script": "^5.0.0",
6464
"chalk": "^4.1.0",
6565
"npm-package-arg": "^10.0.0",
66-
"npmlog": "^7.0.0",
66+
"npmlog": "^7.0.1",
6767
"pacote": "^15.0.2",
6868
"proc-log": "^3.0.0",
6969
"read": "^1.0.7",

0 commit comments

Comments
 (0)