You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems that a change in d3 version 3.4.4 to d3.bisector has broken the interactiveBisect functionality. d3.bisector now supports a comparator argument if the method passed takes two parameters instead of the one needed for an accessor ( https://github.com/mbostock/d3/wiki/Arrays#d3_bisector )
Unfortunately nv.interactiveBisect is passing
function(d,i) { return d.x;}
Which is being interpreted by d3.bisect as a comparator, and stopping the interactiveBisect working, ( it will only hilight the 0th or 1st data point. )
The text was updated successfully, but these errors were encountered:
Looks like a trivially easy fix (remove the i element); not sure if I'm missing something. It certainly is technically a breaking change - d3/d3#1767 - though I'll chalk that one to a possibly drunk programmer with a bad sense of code style.
Could someone explain a little more about this bug. Looking at the nv.interactiveBisect as used in this test. It takes 3 parameters, whereas the template that @bfhobbes posted
@sudheesh001, please check out the development branch as of b014281, you should see that now nvd3 is working with 3.4.4 and later, but NOT with any version earlier.
It seems that a change in d3 version 3.4.4 to d3.bisector has broken the interactiveBisect functionality.
d3.bisector now supports a comparator argument if the method passed takes two parameters instead of the one needed for an accessor ( https://github.com/mbostock/d3/wiki/Arrays#d3_bisector )
Unfortunately nv.interactiveBisect is passing
Which is being interpreted by d3.bisect as a comparator, and stopping the interactiveBisect working, ( it will only hilight the 0th or 1st data point. )
The text was updated successfully, but these errors were encountered: