Skip to content
This repository has been archived by the owner on Feb 11, 2022. It is now read-only.

Use file output to store violations per-tool #43

Closed
mr-archano opened this issue Jan 20, 2018 · 3 comments
Closed

Use file output to store violations per-tool #43

mr-archano opened this issue Jan 20, 2018 · 3 comments

Comments

@mr-archano
Copy link
Contributor

Right now the plugin stores the violations in an in-memory NamedDomainObjectContainer holding an instance of Violations for each of the tool configured. Ideally each tool would instead produce an (xml?) report that can be used as input of the EvaluateViolationsTask. This would also help with the incremental builds, as an input/output file plays nicer with Gradle architecture.

@tasomaniac
Copy link
Contributor

You can define custom Objects to be input/output too. With Property and Providers. (Are they Gradle 4+?) I think they also need to be Serializable then. The incremental build mechanism works like the same. Writing to a file may not be necessary.

@mr-archano
Copy link
Contributor Author

mr-archano commented Feb 13, 2018

@tasomaniac good point, but then 2 things come to mind:

  1. I don't see why we should loose retro-compatibility, even though Gradle 4.x is widely adopted already
  2. I feel like having the output as persisted report can open possibilities we haven't fully figured out yet, even though we can always write the objects as files if we need to

Mmmm 🤔

@tasomaniac
Copy link
Contributor

That may makes sense for other purposes of course. Since all the tools integrated already has output files, it could also be an overhead to have even more files. ☺

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants