Multiple different ' ktlint' plugin references

[lgvalle]

I'm was going through the project documentation and code to setup a new ktlint integration and I found three different references to ktlint plugins:

• org.jlleitschuh.gradle.ktlint in: https://github.com/novoda/gradle-static-analysis-plugin/blob/master/plugin/src/main/groovy/com/novoda/staticanalysis/internal/ktlint/KtlintConfigurator.groovy#L15
• org.jmailen.gradle:kotlinter-gradle in : https://github.com/novoda/gradle-static-analysis-plugin/blob/master/plugin/src/main/groovy/com/novoda/staticanalysis/internal/ktlint/KtlintConfigurator.groovy#L16)
• com.github.shyiko:ktlint in the first ktlint link in : https://github.com/novoda/gradle-static-analysis-plugin/blob/master/docs/tools/ktlint.md and in the table in https://github.com/novoda/gradle-static-analysis-plugin/blob/master/docs/supported-tools.md

Which one is the recommended one?
I believe only the first one is supported since is the one the configurator expects. If that the case we should ammend the documentation.

[mr-archano]

@lgvalle KtLint is a command line, standalone tool (no built-in Gradle support). The links in the docs are correct:

• https://github.com/shyiko/ktlint is the repo of the tool, as mentioned in README.md, docs/supported-tools.md and docs/tools/ktlint
• https://github.com/JLLeitschuh/ktlint-gradle/ is the repo of the supported KtLint Gradle plugin, as mentioned in docs/tools/ktlint.md, where it's also explained the why of this choice.

It appears though that the error message in KtlintConfigurator.groovy#L16 is mentioning the wrong Gradle plugin (it got uncaught since the introduction of support of KtLint in #110). It should be something easy to fix. Feel free to issue a PR :)

[tasomaniac]

Thanks @mr-archano

I was looking at those 2 plugins at the time to see which one is more suitable. I think this was a copy paste mistake. :) The error message seems to be wrong.

[mr-archano]

Fixed in #137

[lgvalle]

Thanks for the explanation & the fix @mr-archano 💯