include full path to the file that triggered the event #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passcod
added a commit
that referenced
this pull request
Mar 5, 2015
Include full path to the file that triggered the event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Event::path, when given by inotify, only gives thePath::file_name, because it has no notion of recursive watches. The good thing is that we already store a map of directory paths to inotify watchers, so we can use that to join the file name in the inotify event. This way, a deeply nested event yields the appropriate, full path, otherwise we have no way of distinguishing separate files with the same name, and therefore make sit impossible to locate the file that the event is for.