Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fsevent dependencies and bump version #196

Merged
merged 1 commit into from
May 7, 2019

Conversation

Eijebong
Copy link
Contributor

@Eijebong Eijebong commented May 6, 2019

No description provided.

@passcod
Copy link
Member

passcod commented May 7, 2019

Ah, this build shows some failures on 1.26.1. Some of it looks like module/paths, should be pretty simple:

error[E0433]: failed to resolve. Use of undeclared type or module `std`
   --> src/fsevent.rs:130:43
    |
130 |             let mut err: cf::CFErrorRef = std::ptr::null_mut();
    |                                           ^^^ Use of undeclared type or module `std`

And some of it is type mismatches, and I'm not super sure what's going on there:

error[E0308]: mismatched types
   --> src/fsevent.rs:107:43
    |
107 |                 while !CFRunLoopIsWaiting(runloop) {
    |                                           ^^^^^^^ expected enum `std::os::raw::c_void`, found enum `libc::c_void`
    |
    = note: expected type `*mut std::os::raw::c_void`
               found type `*mut libc::c_void`

Perhaps some stdlib changes?

@Eijebong
Copy link
Contributor Author

Eijebong commented May 7, 2019

Should be fixed now. I couldn't run the tests but it compiled

@passcod passcod merged commit 1356c5f into notify-rs:try-v4 May 7, 2019
passcod pushed a commit that referenced this pull request May 7, 2019
passcod added a commit to Eijebong/notify that referenced this pull request May 8, 2019
passcod added a commit to Eijebong/notify that referenced this pull request May 8, 2019
passcod added a commit to Eijebong/notify that referenced this pull request May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants