Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move code to notation-core-go #36

Closed
shizhMSFT opened this issue Apr 23, 2022 · 4 comments
Closed

Move code to notation-core-go #36

shizhMSFT opened this issue Apr 23, 2022 · 4 comments
Assignees
@gokarnm
Milestone
alpha-3

Comments

@shizhMSFT
Copy link
Contributor

As discussed in notaryproject/notation#160, all crypto code should be moved to notation-core-go. notation-go should depend on notation-core-go and should implement registry auth and registry interactions, including ORAS APIs, key config, trust store, trust policy, plugin interaction
@shizhMSFT shizhMSFT self-assigned this Apr 23, 2022
@qmuntal qmuntal mentioned this issue May 19, 2022
Merged
@dtzar dtzar added this to the RC-1 milestone Jun 29, 2022
@dtzar dtzar assigned gokarnm and unassigned shizhMSFT Jun 29, 2022
@dtzar
Copy link
Contributor

dtzar commented Jun 29, 2022

Assigning it per what is listed in the spreadsheet. I couldn't assign to @rgnote for some reason.

@dtzar dtzar moved this to In Progress in Notary Project Planning Board Jun 29, 2022
@iamsamirzon
Copy link
Contributor

@iamsamirzon - Checked with @rgnote on 7/13/2022. This is completed except for Timestamping, which is being tracked separately.

@iamsamirzon iamsamirzon moved this from In Progress to Done in Notary Project Planning Board Jul 13, 2022
@rgnote
Copy link
Contributor

rgnote commented Jul 13, 2022

Commits that complete this task. I copied the timestamping code to notation-core-go but haven't removed it from notation-go.

notaryproject/notation-core-go@479e364
notaryproject/notation-core-go@0a8a7fd
notaryproject/notation-core-go@e32e65c

@iamsamirzon
Copy link
Contributor

Closing this task as Timestamping work for RC-1 and RC-2 will be handled separately via issues like
#78 and
#74

@dtzar dtzar modified the milestones: RC-1, alpha-3 Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gokarnm gokarnm

Labels
None yet
Projects
Notary Project Planning Board
Status: Done
Milestone
alpha-3
Development

No branches or pull requests
5 participants
@dtzar @gokarnm @rgnote @shizhMSFT @iamsamirzon