Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for IConfigurationProvider in NAME.AspNetCore #33

Closed
Symbianx opened this issue Jul 18, 2018 · 1 comment · Fixed by #34
Closed

Add support for IConfigurationProvider in NAME.AspNetCore #33

Symbianx opened this issue Jul 18, 2018 · 1 comment · Fixed by #34
Assignees
Milestone

Comments

@Symbianx
Copy link
Contributor

Symbianx commented Jul 18, 2018

With Asp.Net Core, the standard behaviour for managing settings is with the use of the IConfigurationProvider.

The dependencies.json should support a new connectionstring Locator IConfigurationProvider which takes accepts the key element containing the name of the setting as described in the microsoft documentation (i.e. section:subsection:key).

The IConfigurationProvider class is in the Microsoft.Extensions.Configuration.Abstractions nuget package, since we don't want to add this dependency in the main NAME package we need to add an extension point in the DependenciesReader.ReadDependencies method that allows the caller to inject custom IConnectionStringProviders.

Furthermore NAMEAspNetCoreConfiguration should optionally take in the IConfigurationProvider and use the new extension point.

@Symbianx Symbianx added this to the 1.2.0 milestone Jul 18, 2018
@Symbianx Symbianx self-assigned this Jul 18, 2018
@suvl
Copy link
Member

suvl commented Jul 18, 2018

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants