Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wallet): add fallback random generated wallet name #1264

Merged
merged 5 commits into from
Dec 6, 2019

Conversation

DalderupMaurice
Copy link
Member

@DalderupMaurice DalderupMaurice commented Dec 6, 2019

Description

Instead of auto-creating a label, it is now a fallback
Also updated the README with new labels

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@codecov
Copy link

codecov bot commented Dec 6, 2019

Codecov Report

Merging #1264 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1264   +/-   ##
========================================
  Coverage    49.85%   49.85%           
========================================
  Files          248      248           
  Lines         2122     2122           
  Branches       282      282           
========================================
  Hits          1058     1058           
  Misses         886      886           
  Partials       178      178

@DalderupMaurice DalderupMaurice added the PR: good to merge Reviewed and approved label Dec 6, 2019
@DalderupMaurice DalderupMaurice merged commit 5ff6b53 into develop Dec 6, 2019
@DalderupMaurice DalderupMaurice deleted the feature/add-wallet-label branch December 6, 2019 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: good to merge Reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant