Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(settings): added ability to toggle WebGL support #1178

Merged
merged 8 commits into from
Oct 6, 2019

Conversation

DalderupMaurice
Copy link
Member

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@DalderupMaurice DalderupMaurice added the PR: good to merge Reviewed and approved label Oct 6, 2019
@codecov
Copy link

codecov bot commented Oct 6, 2019

Codecov Report

Merging #1178 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1178   +/-   ##
========================================
  Coverage    50.23%   50.23%           
========================================
  Files          240      240           
  Lines         2096     2096           
  Branches       280      280           
========================================
  Hits          1053     1053           
  Misses         867      867           
  Partials       176      176

@DalderupMaurice DalderupMaurice merged commit 3eea62b into develop Oct 6, 2019
@DalderupMaurice DalderupMaurice deleted the feature/webgl-settings branch October 6, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: good to merge Reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant