Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(circleci): fix test coverage issue #1120

Merged
merged 3 commits into from
Aug 23, 2019

Conversation

DalderupMaurice
Copy link
Member

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@9f5696e). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #1120   +/-   ##
==========================================
  Coverage           ?   50.79%           
==========================================
  Files              ?      240           
  Lines              ?     2063           
  Branches           ?      276           
==========================================
  Hits               ?     1048           
  Misses             ?      843           
  Partials           ?      172

1 similar comment
@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@9f5696e). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #1120   +/-   ##
==========================================
  Coverage           ?   50.79%           
==========================================
  Files              ?      240           
  Lines              ?     2063           
  Branches           ?      276           
==========================================
  Hits               ?     1048           
  Misses             ?      843           
  Partials           ?      172

@DalderupMaurice DalderupMaurice added the PR: good to merge Reviewed and approved label Aug 23, 2019
@DalderupMaurice DalderupMaurice merged commit 4c97f03 into develop Aug 23, 2019
@DalderupMaurice DalderupMaurice deleted the chore/circleci-fix-tests branch August 23, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: good to merge Reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant