Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(AppContainer): fix white flicker when opening tab #1102

Merged
merged 3 commits into from
Aug 15, 2019

Conversation

DalderupMaurice
Copy link
Member

Description

Fixes the issue where opening a new tab would flicker white before the page was loaded

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@DalderupMaurice DalderupMaurice added the PR: needs review Pull request label Aug 15, 2019
@codecov
Copy link

codecov bot commented Aug 15, 2019

Codecov Report

Merging #1102 into develop will increase coverage by 0.07%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1102      +/-   ##
===========================================
+ Coverage    50.77%   50.84%   +0.07%     
===========================================
  Files          240      240              
  Lines         2062     2065       +3     
  Branches       275      276       +1     
===========================================
+ Hits          1047     1050       +3     
  Misses         843      843              
  Partials       172      172

@jeroenptrs jeroenptrs added PR: good to merge Reviewed and approved and removed PR: needs review Pull request labels Aug 15, 2019
@DalderupMaurice DalderupMaurice merged commit 5b304c8 into develop Aug 15, 2019
@DalderupMaurice DalderupMaurice deleted the chore/fix-white-flicker branch August 15, 2019 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: good to merge Reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants