Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should themes and site variables be integrated? #27

Closed
oliverlloyd opened this issue Nov 25, 2014 · 15 comments
Closed

How should themes and site variables be integrated? #27

oliverlloyd opened this issue Nov 25, 2014 · 15 comments

Comments

@oliverlloyd
Copy link

I'd really like to use these features - it's stuff like this that makes Semantic so great - but it's not clear how this should work with Meteor.

Clearly the src file needs to exist somewhere but when I tried adding it I couldn't make Semantic pick up my config changes.

If you have an idea how this should be done and could find the time to add an example that would be amazing.

@grp06
Copy link

grp06 commented Nov 26, 2014

I have the same question. Oliverlloyd, let me know if you figure it out

@grp06
Copy link

grp06 commented Nov 26, 2014

Oliverlloyd. If you go into your .meteor folder, you'll see that when you install nooitaf:semantic-ui through terminal, you don't get the same file structure as you do if you look through the files here on github. I still havent't figured it out, but maybe that will help you

@nooitaf
Copy link
Owner

nooitaf commented Nov 28, 2014

Sorry for the late reply.

This should be possible in the future, but at the moment its not. You can however remove this package and add the src folder from the semanti-ui source to a client/ folder in your project. Also add the meteor less package. After that you should be able to use the config file and do your overrides in the _site folder.

I might think something like this..

client/lib/semantic-ui/{src folder contents here}

# and dont forget
meteor add less

This package will change to support theming, but meteor doesn't make it easy at the moment :
We started working at a new official version which has exactly that customising point in mind. But we wont release before its smooth enough.

@oliverlloyd
Copy link
Author

Amazing news about the official integration - Meteor and Semantic put together properly is a formidable combination. Well done.

Note. For others trying to get this temp. workaround setup then you'll have to change the name of theme.less to theme.import.less to stop it being compiled and failing because variables are not set. Obviously, you also have to change the @import reference to this file at the bottom of theme.config to match.

Font-Awesome is also broken but should be fairly simple to patch.

@oliverlloyd
Copy link
Author

To hack fonts to work you can just put a copy of them in the /public folder; either using the folder structure expected in the request:

/public/themes/default/assets/fonts/

or using a symbolic link.

@nooitaf
Copy link
Owner

nooitaf commented Nov 29, 2014

afaik symbolic links disappear on deployment.

@williamkhshea
Copy link

+1 I look forward to official support of theming.

@williamkhshea
Copy link

I'm just wondering if there is any timeline for it?

@javoire
Copy link

javoire commented Jan 15, 2015

+1

@maxpain
Copy link

maxpain commented Jan 27, 2015

+1

@dmalik
Copy link

dmalik commented Feb 5, 2015

FYI - Stumbled across an issue using the src folder method. Modals and other modules relying on transition were not working for me. The culprit turned out to be not using autoprefixer. The solution was to remove the less meteor package and add the lauricio:less-autoprefixer package.

@nooitaf
Copy link
Owner

nooitaf commented Feb 5, 2015

Great info @dmalik, thanks for sharing :)

@MattiSG
Copy link

MattiSG commented Feb 6, 2015

+1

@iSuslov
Copy link

iSuslov commented Sep 13, 2015

This is unacceptable! I spend almost an hour trying to customize it. Please, put a BIG warning that you DON'T support customizing in meteor. And remove this section from documentation on atmosphere. Seriously, for what I should know that there is a folder "/site" and it is EDITABLE. But it does not work! WTF!?

@nooitaf
Copy link
Owner

nooitaf commented Sep 14, 2015

@iSuslov wrong repo?

@nooitaf nooitaf closed this as completed Sep 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants