Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serving-cert-secret-name annotations on OCP 3.11 Services should use alpha not beta in key #117

Closed
ron1 opened this issue Oct 31, 2019 · 0 comments · Fixed by #256
Closed

serving-cert-secret-name annotations on OCP 3.11 Services should use alpha not beta in key #117

ron1 opened this issue Oct 31, 2019 · 0 comments · Fixed by #256
Assignees
@nb-ohad
Milestone
v2.1.0

Comments

@ron1
Copy link

ron1 commented Oct 31, 2019

On OCP 3.11, Service annotation key serving-cert-secret-name should use prefix service.alpha.openshift.io rather than service.beta.openshift.io. The service-generation code should detect the OCP version and generate the annotation key based on the OCP version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nb-ohad nb-ohad

Labels
None yet
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging a pull request may close this issue.

Adding support for serving certs for OCP3 nb-ohad/noobaa-operator
3 participants
@guymguym @ron1 @nb-ohad