Error data property is overwritten between provider and hardhat-web3 adapter

[nazarhussain]

In case of an error been return by the client that error represented as following json rpc response object.

{
  id: 4,
  jsonrpc: '2.0',
  error: {
    code: 3,
    message: 'execution reverted: speed invalid',
    data: '0x08c379a00000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000000d737065656420696e76616c696400000000000000000000000000000000000000'
  }
}

The error response is identified and then thrown as an error object.

https://github.com/nomiclabs/hardhat/blob/fe38c5d12626e4d3b1c0038ed984e7acb8ae0b42/packages/hardhat-core/src/internal/core/providers/http.ts#L57-L62

But the adapter catches this error overwrite the data property of the error and return the response.

https://github.com/nomiclabs/hardhat/blob/fe38c5d12626e4d3b1c0038ed984e7acb8ae0b42/packages/hardhat-web3/src/web3-provider-adapter.ts#L87-L93

which result in invalid handling of the error on the abi coder.

[nazarhussain]

The issue been identified during discussion of web3/web3.js#3742

[fvictorio]

Possibly related to #1882 (not sure).

[github-actions]

This issue was marked as stale because it didn't have any activity in the last 30 days. If you think it's still relevant, please leave a comment indicating so. Otherwise, it will be closed in 7 days.

[github-actions]

This issue was closed because it has been stalled for 7 days with no activity.