Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Provoke handling cycles even with no arbitrary field preservation #343

Closed
5 tasks done
kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Closed
5 tasks done
Labels
archive bug Something isn't working

Comments

@kopf-archiver
Copy link

kopf-archiver bot commented Aug 18, 2020

A pull request by nolar at 2020-04-06 21:53:52+00:00
Original URL: zalando-incubator/kopf#343
Merged by nolar at 2020-04-07 12:06:45+00:00

What do these changes do?

Trigger the after-sleep handling cycles via the progress storage, the same way as it is triggered for the no-sleep handlers.

Description

This aspect was unintentionally forgotten in #331, where the handlers' persistence was made configurable.

If the resource would have no arbitrary field preservation (e.g. for built-in resources), the dummy patching would be silently ignored by K8s API.

With this PR, the dummy patches are made the same way as the regular handlers are patched, so the handling cycles are always provoked after the sleeps.

Issues/PRs

Issues: #308 #23 #283 #321
Related: #331

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • The code addresses only the mentioned problem, and this problem only
  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
@kopf-archiver kopf-archiver bot closed this as completed Aug 18, 2020
@kopf-archiver kopf-archiver bot changed the title [archival placeholder] [PR] Provoke handling cycles even with no arbitrary field preservation Aug 19, 2020
@kopf-archiver kopf-archiver bot added the bug Something isn't working label Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archive bug Something isn't working
Projects
None yet
Development

No branches or pull requests

0 participants