Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Split handers & callbacks types for resource-related handlers #329

Closed
5 tasks done
kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Closed
5 tasks done

[PR] Split handers & callbacks types for resource-related handlers #329

kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Labels
archive refactoring Code cleanup without new features added

Comments

@kopf-archiver
Copy link

kopf-archiver bot commented Aug 18, 2020

A pull request by nolar at 2020-03-12 08:52:51+00:00
Original URL: zalando-incubator/kopf#329
Merged by nolar at 2020-03-18 20:31:40+00:00

What do these changes do?

Move the code around and rename some types & classes for callbacks & handlers.
No user-facing changes.

Description

This is the last preparing PR before the daemons & timers PR (#330).

Here, we just move the code around and rename classes. It would be messy to have these in the daemons & timers PR, so it goes separately.

Specifically, the resource-related handlers are split into resource-changing & resource-watching — same as it is already done for registries. These handlers & callbacks are de factor different anyway, but were declared as the same for laziness reasons. In the daemons & timers PR, also resource-spawning handlers & daemon/timer callbacks will be added with their own signatures.

No behavioural changes, no user-facing changes.

Issues/PRs

Issues: #19

Type of changes

  • Refactoring (non-breaking change which does not alter the behaviour)

Checklist

  • The code addresses only the mentioned problem, and this problem only
  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt

Commented by nolar at 2020-03-16 21:49:27+00:00
 

haikoschol Ouch. One more time plz (with a new commit)?


Commented by haikoschol at 2020-03-18 17:55:19+00:00
 

haikoschol Ouch. One more time plz (with a new commit)?

Sorry about the delay. I saw it yesterday or so but then forgot about it again.

@kopf-archiver kopf-archiver bot closed this as completed Aug 18, 2020
@kopf-archiver kopf-archiver bot changed the title [archival placeholder] [PR] Split handers & callbacks types for resource-related handlers Aug 19, 2020
@kopf-archiver kopf-archiver bot added the refactoring Code cleanup without new features added label Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archive refactoring Code cleanup without new features added
Projects
None yet
Development

No branches or pull requests

0 participants