-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add brillig optimized implementation of sha256 #7
Comments
Main issues are along the lines of this loop not terminating early when reaching the end of the message, having conditional assignment of a pointer, etc. which can all be removed in brillig: Lines 75 to 99 in 8e7ed7f
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current sha256 implementation is optimized for ACIR proving however this results in an unnecessarily high number of brillig opcodes. We can use
std::runtime::is_unconstrained()
to dispatch to an implementation of this which is optimized for brillig.The text was updated successfully, but these errors were encountered: