Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ssa): Update the Brillig constraint SSA check to register descendants coming before the Brillig calls #6735

Closed
rkarabut opened this issue Dec 8, 2024 · 0 comments · Fixed by #7060
Assignees
Labels
enhancement New feature or request

Comments

@rkarabut
Copy link
Contributor

rkarabut commented Dec 8, 2024

Problem

As mentioned in #6658 (review), currently the check's algorithm of collecting tainted value ids doesn't allow to register the descendant values should they come up before the Brillig call, which could lead to false positives, as in

fn main(a: Field, b: Field) {
  let c = a + b;
  let d = unsafe { add(a, b) };
  assert_eq(c, d);
}

Happy Case

Cases like this should be covered, possibly with a lookback pass for the calls found unconstrained by the end of the block.

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

None

Blocker Context

No response

Would you like to submit a PR for this Issue?

Yes

Support Needs

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant