Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some builtin functions are actually foreign #6594

Closed
aakoshh opened this issue Nov 22, 2024 · 0 comments · Fixed by #6892
Closed

Some builtin functions are actually foreign #6594

aakoshh opened this issue Nov 22, 2024 · 0 comments · Fixed by #6892
Assignees
Labels
bug Something isn't working

Comments

@aakoshh
Copy link
Contributor

aakoshh commented Nov 22, 2024

Aim

Tried to implement the bigint functions (part of the BlackBoxFunc family) as foreign in ##6551 , but they are marked as #[builtin] in Noir.

Expected Behavior

Dispatching a builtin function to Interpreter::call_builtin should handle it, while foreign functions should go to Interpreter::call_foreign.

Bug

There is no actual bug at the moment because there are redirects in the interpreter [1, 2], but it's a bit confusing.

To Reproduce

Workaround

None

Workaround Description

The redirect in the code from builtin to foreign handles the mislabeling.

Additional Context

No response

Project Impact

None

Blocker Context

No response

Nargo Version

No response

NoirJS Version

No response

Proving Backend Tooling & Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@aakoshh aakoshh added the bug Something isn't working label Nov 22, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Nov 22, 2024
@TomAFrench TomAFrench moved this from 📋 Backlog to 🏗 In progress in Noir Dec 20, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Noir Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants