Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICE encountered when calling a function marked with #[fold] from brillig #5130

Closed
TomAFrench opened this issue May 29, 2024 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@TomAFrench
Copy link
Member

See PR #5128

Most of the test cases for folding fail to compile if we force it to be compiled into brillig with an ICE. See below:

tom at tom-desktop in ~/Programming/aztec/noir/test_programs/execution_success/fold_fibonacci on tf/enforce-testing-in-brillig [$]
$ nargo compile --force-brillig
error: Internal Consistency Evaluators Errors: 

                    This is likely a bug. Consider opening an issue at https://github.com/noir-lang/noir/issues
  ┌─ std/aes128.nr:1:1
  │
1 │ #[foreign(aes128_encrypt)]
  │ - ICE: "Cannot find linked fn f1"
  │

Aborting due to 1 previous error

If we're compiling in brillig can make a call to a #[fold] function we should be able to just ignore that and treat it as a regular brillig function.

Also this diagnostic is quite odd, not sure why this is pointing at aes128.

@TomAFrench TomAFrench added the bug Something isn't working label May 29, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir May 29, 2024
@TomAFrench
Copy link
Member Author

Would probably benefit from #5121

@TomAFrench TomAFrench assigned asterite and unassigned vezenovm Oct 30, 2024
@asterite
Copy link
Collaborator

I can't seem to reproduce this. I tried nargo compile --force-brillig in some of the fold programs and all compile file.

@TomAFrench
Copy link
Member Author

Looks like we can close this then.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants