Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose loadVerificationKey in backend_barretenberg #3403

Closed
1 task done
signorecello opened this issue Nov 2, 2023 · 1 comment
Closed
1 task done

Expose loadVerificationKey in backend_barretenberg #3403

signorecello opened this issue Nov 2, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request js Noir's JavaScript packages
Milestone

Comments

@signorecello
Copy link
Contributor

signorecello commented Nov 2, 2023

Prerequisite

Preview Give feedback
  1. enhancement js
    michaeljklein

Problem

Sometimes you'd want to actually load an external verification_key instead of initializing one from the circuit. For example, one could load it from the output json of nargo compile --include-keys.

Reason being that it's just faster than having to compute the vk in case you already have it, or you're storing it somewhere on the browser

Happy Case

I want to be able to initialize my Backend instance with a precomputed VK. Example:

const backend = new Barretenberg(circuit, { threads: 8, importVk: true })

This would call acirLoadVerificationKey and load it from the circuit.verification_key field in the compiled circuit.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@signorecello signorecello added the enhancement New feature or request label Nov 2, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Nov 2, 2023
@kevaundray kevaundray added this to the 1.0 milestone Jan 15, 2024
@Savio-Sou Savio-Sou added the js Noir's JavaScript packages label Jan 18, 2024
@Savio-Sou Savio-Sou moved this from 📋 Backlog to 🤔 Grooming in Noir Feb 9, 2024
@Savio-Sou Savio-Sou moved this from 🤔 Grooming to 📋 Backlog in Noir Feb 16, 2024
@Savio-Sou Savio-Sou moved this from 📋 Backlog to 🚧 Blocked in Noir Mar 15, 2024
@Savio-Sou Savio-Sou moved this from 🚧 Blocked to 📋 Backlog in Noir Mar 15, 2024
@TomAFrench
Copy link
Member

Closing this as the only time it would make sense to use is when you're just verifying an externally produced proof, at which point you would use @michaeljklein's work on #3450

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request js Noir's JavaScript packages
Projects
Archived in project
Development

No branches or pull requests

4 participants