Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Auto-Formatting to noir_lsp #3400

Closed
ghost opened this issue Nov 2, 2023 · 3 comments · Fixed by #3433
Closed

Add Auto-Formatting to noir_lsp #3400

ghost opened this issue Nov 2, 2023 · 3 comments · Fixed by #3433
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Nov 2, 2023

Problem

To add auto-formatting to a language server protocol (LSP) implementation like "noir_lsp" for the "Save" functionality, you would typically want to incorporate a code formatting feature that triggers when a user saves a file. This is a common and useful feature in code editors to ensure that the code is consistently formatted.

Happy Case

Alternatives Considered

No response

Additional Context

It seems that there are three events for this: OnTypeFormatting, Formatting, RangeFormatting

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@ghost ghost added the enhancement New feature or request label Nov 2, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Nov 2, 2023
@ghost ghost changed the title Add Auto-Formatting to noir_lsp for "Save" Functionality Add Auto-Formatting to noir_lsp Nov 2, 2023
@ghost ghost mentioned this issue Nov 6, 2023
5 tasks
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Nov 22, 2023
@Savio-Sou
Copy link
Collaborator

Duplicate of #1581? (I.e. safe to close that?)

@ghost
Copy link
Author

ghost commented Nov 27, 2023

Apologies for the noise. Couldn't locate the issue, but it seems we might need to open two more issues for two events: RangeFormatting and OnTypeFormatting.

@Savio-Sou
Copy link
Collaborator

Not at all and thank you for the context!

Will close that issue when the remaining two events are addressed in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant