Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nargo): remove misleading quotes in generated Prover.toml #1087

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

TomAFrench
Copy link
Member

Related issue(s)

Resolves #

Description

Summary of changes

Currently running nargo check on a new project generates the Prover.toml file as below

x = ""
y = "[]"

This isn't ideal as unless users remove the quotes around the array, they'll get the error message Error: cannot parse a string toml type into Array { length: 2, typ: Field }.

This PR updates build_placeholder_input_map so that we get the generated toml file

x = ""
y = []

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

@TomAFrench TomAFrench requested a review from kobyhallx April 3, 2023 14:59
@TomAFrench TomAFrench force-pushed the remove-array-quotes branch from 1456be7 to 5ba54a4 Compare April 3, 2023 15:00
@TomAFrench TomAFrench enabled auto-merge April 3, 2023 15:28
@TomAFrench TomAFrench added this pull request to the merge queue Apr 3, 2023
Merged via the queue into master with commit 57c817f Apr 3, 2023
@TomAFrench TomAFrench deleted the remove-array-quotes branch April 3, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants