Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nargo): only search for Nargo.toml in commands which act on a Nargo package #1029

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

ax0
Copy link
Contributor

@ax0 ax0 commented Mar 23, 2023

Related issue(s)

Resolves #

Description

This PR fixes the issue where running nargo new unsuccessfully searches for a Nargo.toml file resulting in an error of the following form:

Error: cannot find a Nargo.toml in /tmp

Location:
    crates/nargo/src/cli/mod.rs:67:26

Summary of changes

  • Condition added to check command before searching for project root.

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

@ax0 ax0 changed the title Fix new command. fix(nargo): Fix new command. Mar 23, 2023
@kevaundray kevaundray requested a review from TomAFrench March 23, 2023 12:05
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@TomAFrench TomAFrench changed the title fix(nargo): Fix new command. fix(nargo): only search for Nargo.toml in commands which act on a Nargo package Mar 23, 2023
@TomAFrench TomAFrench added this pull request to the merge queue Mar 23, 2023
Merged via the queue into noir-lang:master with commit 6e642b9 Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants