Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate impact of upgrade to sphinx 2.0.0 and python 3.7 for building. #47

Closed
stefanodavid opened this issue Mar 25, 2019 · 4 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@stefanodavid
Copy link
Collaborator

python-sphinx 2.0.0 (currently in beta/RC stage) will drop support for python 2.7 and 3.5 and will require python 3.7. Check what version(s) currently support(s) rtd, what are their plans, and act accordingly.

@stefanodavid stefanodavid added enhancement New feature or request in progress Working on the issue labels Mar 25, 2019
@stefanodavid stefanodavid self-assigned this Mar 25, 2019
@stefanodavid
Copy link
Collaborator Author

I locally already use a wrapper that calls sphinx-build using the python3.7 interpreter without any problem. This will avoid any problem with python 2.7's EOL from next January.
Sphinx 2.0.0 has been released and will be evaluated in the next months. Apparently, conf.py file will need a different syntax, therefore before upgrading it is necessary to make sure to update it as well.

@stefanodavid stefanodavid added on hold Not currenlty working on the issue and removed in progress Working on the issue labels May 3, 2019
@stefanodavid
Copy link
Collaborator Author

I upgraded Sphinx to 2.1.2 and it works; the wrapper seems to already use python3. I will try it on a vanilla system where there is no python 2 installed. Still to check support for python3 on RTD.

@stefanodavid
Copy link
Collaborator Author

I set the interpreter on rtd to python 3.x (which should be 3.7 if I am not mistaken), but they still use Sphinx 1.8.5.
There is however neither an error message, nor any warning, so it seems we're on the right trail! 👍

@stefanodavid
Copy link
Collaborator Author

After a bit of research, I found in the readthedocs repo, that issue 5604 is open for supporting Sphinx 2.0 on their side.

I think I am not using many Sphinx 2.0 features, (probably none at all), so unless I found serious errors in the builds on rtd, I won't be worried about this issue anymore. I close this issue for the time being.

@stefanodavid stefanodavid removed the on hold Not currenlty working on the issue label Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant