Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

socket timeout #439

Closed
ronag opened this issue Sep 25, 2020 · 3 comments
Closed

socket timeout #439

ronag opened this issue Sep 25, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@ronag
Copy link
Member

ronag commented Sep 25, 2020

Not sure if user land bug but after #435 I'm getting some timeouts. Maybe those timeouts not occurring was a bug before.

Needs further investigating to determine whether we've introduced a new bug or not.

@ronag ronag added the bug Something isn't working label Sep 25, 2020
@szmarczak
Copy link
Member

szmarczak commented Sep 25, 2020

What do you think about integrating https://github.com/sindresorhus/got/blob/master/source/core/utils/timed-out.ts into undici? Or should that be left as another module?

The end user API looks like https://github.com/sindresorhus/got#timeout

@ronag ronag added enhancement New feature or request and removed bug Something isn't working labels Sep 25, 2020
@ronag
Copy link
Member Author

ronag commented Sep 25, 2020

Problem probably in userland and related to nodejs/node#35341.

@ronag
Copy link
Member Author

ronag commented Sep 25, 2020

What do you think about integrating https://github.com/sindresorhus/got/blob/master/source/core/utils/timed-out.ts into undici? Or should that be left as another module?

The end user API looks like sindresorhus/got#timeout

That looks very intersting! I'll dig into it next week.

@ronag ronag closed this as completed Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants