Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting custom kProxyHeaders #1876

Closed
Sebmaster opened this issue Jan 22, 2023 · 3 comments · Fixed by #1877
Closed

Allow setting custom kProxyHeaders #1876

Sebmaster opened this issue Jan 22, 2023 · 3 comments · Fixed by #1877
Labels
enhancement New feature or request

Comments

@Sebmaster
Copy link
Contributor

Sebmaster commented Jan 22, 2023

This would solve...

ProxyAgent currently only allows configuring the Authorization header for its CONNECT request to the proxy. I'd like to add different custom headers (e.g. User-Agent) as well. This header should only be sent in the CONNECT request, not in the tunneled requests to the target URL.

The implementation should look like...

I think providing a way to add more headers to kProxyHeaders - possibly just an arbitrary headers object in the options param?

@Sebmaster Sebmaster added the enhancement New feature or request label Jan 22, 2023
@KhafraDev
Copy link
Member

cc @RafaelGSS

@RafaelGSS
Copy link
Member

Would you like to send a Pull Request to address this issue? Remember to add unit tests.

@Sebmaster
Copy link
Contributor Author

Done: #1877.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants