Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Keep-Alive #1861

Open
ronag opened this issue Jan 18, 2023 · 2 comments
Open

Improve Keep-Alive #1861

ronag opened this issue Jan 18, 2023 · 2 comments
Labels
enhancement New feature or request Status: help-wanted This issue/pr is open for contributions

Comments

@ronag
Copy link
Member

ronag commented Jan 18, 2023

llhttp will in certain edge cases (e.g. HEAD, 204, 304) not allow keep-alive to avoid undetectable parsing failures which can lead to data corruption. These can occur when the target server does not properly implement the HTTP/1.1 specification and this is not entirely uncommon.

However, when the target server is known to be spec compliant, this can lead to performance degradation. A typical case for this is when building a microservice architecture where the different services communicate over HTTP/1.1, and the target server is known.

We recently fixed the case for HEAD requests, but more work can be done here.

@ronag ronag added enhancement New feature or request Status: help-wanted This issue/pr is open for contributions labels Jan 18, 2023
@metcoder95
Copy link
Member

At an llhttp level or within undici? And what else do you have in mind exactly?
wanting to understand the full context 🙂

@ronag
Copy link
Member Author

ronag commented Jan 18, 2023

We can fix it at either level. I think undici is probably easiest for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Status: help-wanted This issue/pr is open for contributions
Projects
None yet
Development

No branches or pull requests

2 participants