Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of _prefixed properties of the EventEmitter. #141

Closed
ChALkeR opened this issue Jun 10, 2015 · 1 comment
Closed

Usage of _prefixed properties of the EventEmitter. #141

ChALkeR opened this issue Jun 10, 2015 · 1 comment

Comments

@ChALkeR
Copy link
Member

ChALkeR commented Jun 10, 2015

Atm, readable-stream uses «private» _events property of the EventEmitter:
_stream_readable.js#L588-L595.

While this is (arguably) reasonable inside the node/iojs core itself, but it could cause long-term negative consenquences with the readable-stream package.

There are a lot of packages that depend on readable-stream, and binding to a fixed EventEmitter implementation makes all that packages that use readable-stream bound to the same fixed implementation. Some of them fix minor version of readable-stream, some of them fix even the patch version.

This tightens the fixation on the details of the EventEmitter implementation and to which extent it could be changed in further node/iojs versions.

@ChALkeR
Copy link
Member Author

ChALkeR commented Jun 10, 2015

nodejs/node#1817

@ChALkeR ChALkeR changed the title Usage of _prefixed properties of the EventEmmiter. Usage of _prefixed properties of the EventEmitter. Jun 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants