-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update module.builtinModules
sentence
#57089
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
dario-piotrowicz:dario/docs/commonjs-page/builtinModules
Feb 16, 2025
Merged
doc: update module.builtinModules
sentence
#57089
nodejs-github-bot
merged 1 commit into
nodejs:main
from
dario-piotrowicz:dario/docs/commonjs-page/builtinModules
Feb 16, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates the sentence saying that `module.builtinModule` only contains the modules that can be loaded without `node:` (since v23.5.0 also prefix-only modules are included in the list)
Review requested:
|
aduh95
approved these changes
Feb 16, 2025
jasnell
approved these changes
Feb 16, 2025
ljharb
approved these changes
Feb 16, 2025
Fast-track has been requested by @jasnell. Please 👍 to approve. |
cjihrig
approved these changes
Feb 16, 2025
Landed in f1b951f |
targos
pushed a commit
that referenced
this pull request
Feb 17, 2025
updates the sentence saying that `module.builtinModule` only contains the modules that can be loaded without `node:` (since v23.5.0 also prefix-only modules are included in the list) PR-URL: #57089 Refs: #56185 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
6 tasks
acidiney
pushed a commit
to acidiney/node
that referenced
this pull request
Feb 23, 2025
updates the sentence saying that `module.builtinModule` only contains the modules that can be loaded without `node:` (since v23.5.0 also prefix-only modules are included in the list) PR-URL: nodejs#57089 Refs: nodejs#56185 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
baking-for-lts
PRs that need to wait before landing in a LTS release.
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
module
Issues and PRs related to the module subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates the sentence saying that
module.builtinModule
only contains the modules that can be loaded withoutnode:
(since v23.5.0 also prefix-only modules are included in the list)Refs: #56185