Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update module.builtinModules sentence #57089

Conversation

dario-piotrowicz
Copy link
Contributor

@dario-piotrowicz dario-piotrowicz commented Feb 16, 2025

updates the sentence saying that module.builtinModule only contains the modules that can be loaded without node: (since v23.5.0 also prefix-only modules are included in the list)

Refs: #56185

updates the sentence saying that `module.builtinModule`
only contains the modules that can be loaded without
`node:` (since v23.5.0 also prefix-only modules are
included in the list)
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Feb 16, 2025
@aduh95 aduh95 added the baking-for-lts PRs that need to wait before landing in a LTS release. label Feb 16, 2025
@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 16, 2025
Copy link
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 16, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 16, 2025
@nodejs-github-bot nodejs-github-bot merged commit f1b951f into nodejs:main Feb 16, 2025
34 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f1b951f

targos pushed a commit that referenced this pull request Feb 17, 2025
updates the sentence saying that `module.builtinModule`
only contains the modules that can be loaded without
`node:` (since v23.5.0 also prefix-only modules are
included in the list)

PR-URL: #57089
Refs: #56185
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
acidiney pushed a commit to acidiney/node that referenced this pull request Feb 23, 2025
updates the sentence saying that `module.builtinModule`
only contains the modules that can be loaded without
`node:` (since v23.5.0 also prefix-only modules are
included in the list)

PR-URL: nodejs#57089
Refs: nodejs#56185
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
baking-for-lts PRs that need to wait before landing in a LTS release. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. module Issues and PRs related to the module subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants