From aad1ed80df7710903eaff5529407036ed1353f6a Mon Sep 17 00:00:00 2001
From: Alena Khineika <alena.khineika@gmail.com>
Date: Thu, 30 Jun 2022 12:30:47 +0200
Subject: [PATCH] src: turn embedder api overload into default argument

---
 src/node.cc | 7 -------
 src/node.h  | 7 +------
 2 files changed, 1 insertion(+), 13 deletions(-)

diff --git a/src/node.cc b/src/node.cc
index 78e93c74d3c3c4..c98e77a50c6241 100644
--- a/src/node.cc
+++ b/src/node.cc
@@ -875,13 +875,6 @@ int ProcessGlobalArgs(std::vector<std::string>* args,
 
 static std::atomic_bool init_called{false};
 
-int InitializeNodeWithArgs(std::vector<std::string>* argv,
-                           std::vector<std::string>* exec_argv,
-                           std::vector<std::string>* errors) {
-  return InitializeNodeWithArgs(argv, exec_argv, errors,
-                                ProcessFlags::kNoFlags);
-}
-
 int InitializeNodeWithArgs(std::vector<std::string>* argv,
                            std::vector<std::string>* exec_argv,
                            std::vector<std::string>* errors,
diff --git a/src/node.h b/src/node.h
index e866fcd9369a5c..3191be716cda99 100644
--- a/src/node.h
+++ b/src/node.h
@@ -250,16 +250,11 @@ NODE_EXTERN int Stop(Environment* env);
 // from argv, fill exec_argv, and possibly add errors resulting from parsing
 // the arguments to `errors`. The return value is a suggested exit code for the
 // program; If it is 0, then initializing Node.js succeeded.
-NODE_EXTERN int InitializeNodeWithArgs(
-    std::vector<std::string>* argv,
-    std::vector<std::string>* exec_argv,
-    std::vector<std::string>* errors);
-// TODO(zcbenz): Turn above overloaded version into below's default argument.
 NODE_EXTERN int InitializeNodeWithArgs(
     std::vector<std::string>* argv,
     std::vector<std::string>* exec_argv,
     std::vector<std::string>* errors,
-    ProcessFlags::Flags flags);
+    ProcessFlags::Flags flags = ProcessFlags::kNoFlags);
 
 enum OptionEnvvarSettings {
   kAllowedInEnvironment,