From 6771547269f7251a71524e38c681b2b443c5a287 Mon Sep 17 00:00:00 2001 From: Mikael Finstad Date: Fri, 11 Mar 2022 15:26:41 +0700 Subject: [PATCH 1/6] doc: improve pipe description I spent hours trying to make it work only to learn that it's not supported in node anymore, so I thought I'd save other people the time in the future. https://groups.google.com/g/nodejs/c/SxNKLclbM5k?pli=1 --- doc/api/child_process.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/api/child_process.md b/doc/api/child_process.md index f92636a7ebce44..9c121808a8d251 100644 --- a/doc/api/child_process.md +++ b/doc/api/child_process.md @@ -806,7 +806,9 @@ pipes between the parent and child. The value is one of the following: The parent end of the pipe is exposed to the parent as a property on the `child_process` object as [`subprocess.stdio[fd]`][`subprocess.stdio`]. Pipes created for fds 0, 1, and 2 are also available as [`subprocess.stdin`][], - [`subprocess.stdout`][] and [`subprocess.stderr`][], respectively. + [`subprocess.stdout`][] and [`subprocess.stderr`][], respectively. Note that + these are not actual UNIX pipes and therefore the child process can not use + them by their descriptor files, e.g. `/dev/fd/2` or `/dev/stdout`. 2. `'overlapped'`: Same as `'pipe'` except that the `FILE_FLAG_OVERLAPPED` flag is set on the handle. This is necessary for overlapped I/O on the child process's stdio handles. See the From 4db86b2e4098bf63fba752fe0ec1c163929874a7 Mon Sep 17 00:00:00 2001 From: Mikael Finstad Date: Fri, 11 Mar 2022 15:33:50 +0700 Subject: [PATCH 2/6] doc: fix lint --- doc/api/child_process.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/api/child_process.md b/doc/api/child_process.md index 9c121808a8d251..f828a5e5d235d4 100644 --- a/doc/api/child_process.md +++ b/doc/api/child_process.md @@ -806,8 +806,8 @@ pipes between the parent and child. The value is one of the following: The parent end of the pipe is exposed to the parent as a property on the `child_process` object as [`subprocess.stdio[fd]`][`subprocess.stdio`]. Pipes created for fds 0, 1, and 2 are also available as [`subprocess.stdin`][], - [`subprocess.stdout`][] and [`subprocess.stderr`][], respectively. Note that - these are not actual UNIX pipes and therefore the child process can not use + [`subprocess.stdout`][] and [`subprocess.stderr`][], respectively. + These are not actual Unix pipes and therefore the child process can not use them by their descriptor files, e.g. `/dev/fd/2` or `/dev/stdout`. 2. `'overlapped'`: Same as `'pipe'` except that the `FILE_FLAG_OVERLAPPED` flag is set on the handle. This is necessary for overlapped I/O on the child From e307d1ca94e2978d367b626e4bebb0c21ce034ce Mon Sep 17 00:00:00 2001 From: Mikael Finstad Date: Fri, 11 Mar 2022 17:22:14 +0700 Subject: [PATCH 3/6] Update doc/api/child_process.md --- doc/api/child_process.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/child_process.md b/doc/api/child_process.md index f828a5e5d235d4..b6967bdc3a3c5a 100644 --- a/doc/api/child_process.md +++ b/doc/api/child_process.md @@ -807,7 +807,7 @@ pipes between the parent and child. The value is one of the following: `child_process` object as [`subprocess.stdio[fd]`][`subprocess.stdio`]. Pipes created for fds 0, 1, and 2 are also available as [`subprocess.stdin`][], [`subprocess.stdout`][] and [`subprocess.stderr`][], respectively. - These are not actual Unix pipes and therefore the child process can not use + Currently these are not actual Unix pipes and therefore the child process can not use them by their descriptor files, e.g. `/dev/fd/2` or `/dev/stdout`. 2. `'overlapped'`: Same as `'pipe'` except that the `FILE_FLAG_OVERLAPPED` flag is set on the handle. This is necessary for overlapped I/O on the child From e78e294c4a207e9b49dfe66ed238ad939758f96d Mon Sep 17 00:00:00 2001 From: Mikael Finstad Date: Fri, 11 Mar 2022 17:32:07 +0700 Subject: [PATCH 4/6] Update child_process.md --- doc/api/child_process.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/api/child_process.md b/doc/api/child_process.md index b6967bdc3a3c5a..25e8d4f9461e68 100644 --- a/doc/api/child_process.md +++ b/doc/api/child_process.md @@ -807,8 +807,8 @@ pipes between the parent and child. The value is one of the following: `child_process` object as [`subprocess.stdio[fd]`][`subprocess.stdio`]. Pipes created for fds 0, 1, and 2 are also available as [`subprocess.stdin`][], [`subprocess.stdout`][] and [`subprocess.stderr`][], respectively. - Currently these are not actual Unix pipes and therefore the child process can not use - them by their descriptor files, e.g. `/dev/fd/2` or `/dev/stdout`. + Currently these are not actual Unix pipes and therefore the child process can + not use them by their descriptor files, e.g. `/dev/fd/2` or `/dev/stdout`. 2. `'overlapped'`: Same as `'pipe'` except that the `FILE_FLAG_OVERLAPPED` flag is set on the handle. This is necessary for overlapped I/O on the child process's stdio handles. See the From 0f67f510be002587356c7d55f3249733723f942b Mon Sep 17 00:00:00 2001 From: Mikael Finstad Date: Fri, 11 Mar 2022 21:11:39 +0700 Subject: [PATCH 5/6] Update doc/api/child_process.md Co-authored-by: Rich Trott --- doc/api/child_process.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/child_process.md b/doc/api/child_process.md index 25e8d4f9461e68..50a479ac33687c 100644 --- a/doc/api/child_process.md +++ b/doc/api/child_process.md @@ -807,7 +807,7 @@ pipes between the parent and child. The value is one of the following: `child_process` object as [`subprocess.stdio[fd]`][`subprocess.stdio`]. Pipes created for fds 0, 1, and 2 are also available as [`subprocess.stdin`][], [`subprocess.stdout`][] and [`subprocess.stderr`][], respectively. - Currently these are not actual Unix pipes and therefore the child process can + Currently, these are not actual Unix pipes and therefore the child process can not use them by their descriptor files, e.g. `/dev/fd/2` or `/dev/stdout`. 2. `'overlapped'`: Same as `'pipe'` except that the `FILE_FLAG_OVERLAPPED` flag is set on the handle. This is necessary for overlapped I/O on the child From 7e6fbbebed8b60f4c6b34754b4f812e9128f5a09 Mon Sep 17 00:00:00 2001 From: Mikael Finstad Date: Fri, 11 Mar 2022 21:17:14 +0700 Subject: [PATCH 6/6] Update child_process.md --- doc/api/child_process.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/api/child_process.md b/doc/api/child_process.md index 50a479ac33687c..de988c25b0787e 100644 --- a/doc/api/child_process.md +++ b/doc/api/child_process.md @@ -807,8 +807,9 @@ pipes between the parent and child. The value is one of the following: `child_process` object as [`subprocess.stdio[fd]`][`subprocess.stdio`]. Pipes created for fds 0, 1, and 2 are also available as [`subprocess.stdin`][], [`subprocess.stdout`][] and [`subprocess.stderr`][], respectively. - Currently, these are not actual Unix pipes and therefore the child process can - not use them by their descriptor files, e.g. `/dev/fd/2` or `/dev/stdout`. + Currently, these are not actual Unix pipes and therefore the child process + can not use them by their descriptor files, + e.g. `/dev/fd/2` or `/dev/stdout`. 2. `'overlapped'`: Same as `'pipe'` except that the `FILE_FLAG_OVERLAPPED` flag is set on the handle. This is necessary for overlapped I/O on the child process's stdio handles. See the