From 58c2ab78dbe72a7058ac2e67225c32e83e8b78c8 Mon Sep 17 00:00:00 2001 From: "Hachimi Aa (Sfeir)" Date: Thu, 22 Aug 2019 16:48:57 +0200 Subject: [PATCH 1/5] fix fs.read documentation typo read instead of write --- doc/api/fs.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/api/fs.md b/doc/api/fs.md index 1c3742903affde..f19621988259a2 100644 --- a/doc/api/fs.md +++ b/doc/api/fs.md @@ -2503,9 +2503,9 @@ changes: Read data from the file specified by `fd`. -`buffer` is the buffer that the data will be written to. +`buffer` is the buffer that the data will be reading from. -`offset` is the offset in the buffer to start writing at. +`offset` is the offset in the buffer to start reading from. `length` is an integer specifying the number of bytes to read. From 2fa552caf037a893c624b1beeea351cc3e11207f Mon Sep 17 00:00:00 2001 From: hachimi ahmed amine Date: Thu, 22 Aug 2019 17:02:10 +0200 Subject: [PATCH 2/5] Update doc/api/fs.md Co-Authored-By: Robert Nagy --- doc/api/fs.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/fs.md b/doc/api/fs.md index f19621988259a2..4c8295b32ca205 100644 --- a/doc/api/fs.md +++ b/doc/api/fs.md @@ -2503,7 +2503,7 @@ changes: Read data from the file specified by `fd`. -`buffer` is the buffer that the data will be reading from. +`buffer` is the buffer that the data will be read from. `offset` is the offset in the buffer to start reading from. From 9c6068d11e75525e4f3df6653bec0205a1baeb1b Mon Sep 17 00:00:00 2001 From: hachimi ahmed amine Date: Tue, 27 Aug 2019 14:30:49 +0200 Subject: [PATCH 3/5] Update doc/api/fs.md Co-Authored-By: Anna Henningsen --- doc/api/fs.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/fs.md b/doc/api/fs.md index 4c8295b32ca205..00a9ac88f807f2 100644 --- a/doc/api/fs.md +++ b/doc/api/fs.md @@ -2503,7 +2503,7 @@ changes: Read data from the file specified by `fd`. -`buffer` is the buffer that the data will be read from. +`buffer` is the buffer that the data which was read from the fd will be written to. `offset` is the offset in the buffer to start reading from. From a6387e42a8ad94ee78002bda9e0c2cf3a09955d4 Mon Sep 17 00:00:00 2001 From: "Hachimi Aa (Sfeir)" Date: Sun, 12 Jan 2020 10:10:04 +0100 Subject: [PATCH 4/5] keep writing at in offset params in fs.read --- doc/api/fs.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/fs.md b/doc/api/fs.md index 00a9ac88f807f2..16dfc87aa80ac9 100644 --- a/doc/api/fs.md +++ b/doc/api/fs.md @@ -2505,7 +2505,7 @@ Read data from the file specified by `fd`. `buffer` is the buffer that the data which was read from the fd will be written to. -`offset` is the offset in the buffer to start reading from. +`offset` is the offset in the buffer to start writing at. `length` is an integer specifying the number of bytes to read. From 6e2ab879c80ea4af7e0ec3b8570f611484b30cd3 Mon Sep 17 00:00:00 2001 From: "Hachimi Aa (Sfeir)" Date: Tue, 14 Jan 2020 14:13:47 +0100 Subject: [PATCH 5/5] reduce fs.read buffer line size --- doc/api/fs.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/fs.md b/doc/api/fs.md index 16dfc87aa80ac9..0dddd2b3b50dbf 100644 --- a/doc/api/fs.md +++ b/doc/api/fs.md @@ -2503,7 +2503,7 @@ changes: Read data from the file specified by `fd`. -`buffer` is the buffer that the data which was read from the fd will be written to. +`buffer` is the buffer that the data (read from the fd) will be written to. `offset` is the offset in the buffer to start writing at.